Solr fulltext indexing #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Backport the index fields from the old deployment. - No test changes, because no test coverage on this view at all. This is just a dirty MVP checkpoint. It works but the schema needs cleaning up.
Also: provide upgrade, adjust tests
ale-rt
requested changes
Sep 26, 2025
| - poppler_utils (pdf) | ||
| - html-tidy (cleans up the html that will be converted to pdf) | ||
|
|
||
| Solr: cave canem |
Member
There was a problem hiding this comment.
I am pretty sure you can configure the port and avoid the problem.
Collaborator
Author
There was a problem hiding this comment.
Oh I tried. But the actual startup ignores any custom port and starts with the buildout configured port.
https://github.com/collective/collective.solr/blob/1d65570fd9270d465317469796f17a7b351bd4d5/src/collective/solr/testing.py#L61
In order to keep this PR small and focused I've extracted fixing that into a subtask https://github.com/syslabcom/scrum/issues/3974
Member
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
Like I said, I tried. And found out that the port is not passed to the solr start script.
ale-rt
reviewed
Sep 26, 2025
ale-rt
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs https://github.com/syslabcom/scrum/issues/3147
See the corresponding recensio.buildout PR for a fix for the fulltext indexing of standalone files, and for working with this package in a pre-configured development environment.
The solr config here is identical to the one in the corresponding recensio.buildout PR. The config is based on the collective.solr provided configuration, with indexes added that I took from the old solr configuration in recensio.deployment.