remove unnecessary longjmp when task is last #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
requested changes
Apr 21, 2025
There was a problem hiding this comment.
Check https://cbea.ms/git-commit/ carefully and enforce the rules.
Avoid jumping back to the scheduler after task1 completes, since it's the last scheduled task. Control can return naturally.
|
This commit complies with the seven rules described at https://cbea.ms/git-commit/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since task1 is the last task in the task queue, there is no need
to perform a longjmp(sched, 1) after it completes. Returning
directly avoids unnecessary scheduling logic and simplifies
control flow.