Fix kernel panic when unload bh_threaded module#320
Merged
Conversation
jserv
requested changes
May 8, 2025
Contributor
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Use clang-format to ensure the consistent coding style.
Contributor
|
You don't have to close and submit another pull request if you want to refine the commits. Instead, use |
Ensuring the free_irq function properly releases IRQs for buttons, call free_irq() with button's device handler instead of NULL.
xhorn-pan
force-pushed
the
bh-thread-rmmod-panic-fix
branch
from
44aeac0 to
d30d811
Compare
Contributor
Author
|
Little bit embarrassing, not clang-format but c-pointer problem. |
Contributor
|
Thank @xhorn-pan for contributing! |
Contributor
Author
|
Thank you for writing and maintaining this book, I am learned a lot and still learning from it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensuring the free_irq function properly releases IRQs for buttons, call free_irq() with button's device handler instead of NULL.
Summary by Bito
This pull request resolves a kernel panic issue by ensuring the free_irq function is called with the correct device handler when unloading the bh_threaded module. This enhancement improves the stability and reliability of IRQ management for button devices.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2 - The changes are straightforward and primarily focus on fixing a specific issue, making the review process relatively simple.