fix(css): Prevent transforming @page properties like size #2341
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e358912:
|
| const x = styles[key as keyof typeof styles] | ||
| const val = typeof x === 'function' ? x(theme) : x | ||
|
|
||
| if (val && typeof val === 'object') { |
There was a problem hiding this comment.
I agree that this is the implementation for the solution, but I'm very conflicted about having a special case for @page.
It feels bad, doesn't it? Could we maybe... choose a different solution?
There's no perfect solution here, but I suppose I'd rather resign from the size shorthand and add w and h shorthands in its place.
An alternative we could consider — could we just not implement anything?
There's an escape hatch with css prop, Safari doesn't support @page. Seems less correct than dropping the size alias, and we'd probably need an error thrown only in development, but it's something 🤷
There was a problem hiding this comment.
w/h shorthands will require changes by a significant percentage of Theme UI users & seems like a price they shouldn’t have to pay to me. The number of people using @page is likely tiny, & it’s very easy to update what code in the extremely rare case this change breaks it (imagine usages of that selector to find & replace vs “size” in a codebase). This isn’t very correct but it just doesn’t seem like a common issue to be sad about not getting your (screen-optimized) theme as automatically accessible in printing page setup for some browsers.
Closes #2166. This may not be ideal because it prevents transforms of all properties inside
@page, but the way our transform function is setup, it doesn't seem easy to fix otherwise. This means use of margin properties inside@pagewill no longer be transformed; in my experience you're only using those properties so you can define physical units likein&cminstead of pixels, so doesn't seem like a big deal to me.