Added a "Pick Your Shape" selector to switch between rounded edges and a perfect circle.#68
Open
JPerez00 wants to merge 2 commits intot3dotgg:mainfrom
Open
Added a "Pick Your Shape" selector to switch between rounded edges and a perfect circle.#68JPerez00 wants to merge 2 commits intot3dotgg:mainfrom
JPerez00 wants to merge 2 commits intot3dotgg:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Owner
|
A bit confusing ux-wise with the "circle" option being a checkbox (while also leaving the border-radius selected). I don't have an obvious answer but this isn't it. Might even be better to have it as a separate tool 🤔 |
t3dotgg
requested changes
Nov 13, 2024
Owner
t3dotgg
left a comment
t3dotgg
left a comment
There was a problem hiding this comment.
Blocking until we find a better way to represent the states
JPerez00
force-pushed
the
perfect-circle-toggle
branch
from
72a39c9 to
70abfc0
Compare
Author
|
Thanks for the feedback, and sorry for the time wasted. Ok, so I replaced the circle checkbox with a "Shape" selector titled "Pick Your Shape" for dumb people like me lol. pick.your.shape.mp4Ran the checks, no issues.
I thought about making it a separate tool, but it felt like extra bulk (files and folders, etc). Let me know if this works for you. |
JPerez00
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new feature to the RoundedTool that allows users to make images perfectly circular, regardless of their original aspect ratio. This is implemented via a new "Make image a circle" checkbox toggle.
It’d be awesome to add X/Y controls to choose the crop spot, but that’s a bit out of my league. Also had to also update the
border-radius-selector.tsxcomponent to make it work.