Skip to content

fix: amount in cashback message #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: amount in cashback message #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
14f4091
Fix
Shvandre Aug 21, 2025
269ebf6
Merge branch 'main' into fix-amount-in-cashback
Shvandre Aug 21, 2025
340906b
gas
Shvandre Aug 21, 2025
d6271f8
gas
Shvandre Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions src/benchmarks/results_gas.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,32 @@
"claimWallet": "3984"
},
"summary": "80094"
},
{
"label": "Fixed amount in cashback message",
"pr": "https://github.com/tact-lang/jetton/pull/180",
"gas": {
"transfer": "34145",
"mint": "18842",
"burn": "12846",
"discovery": "5945",
"reportBalance": "4308",
"claimWallet": "3984"
},
"summary": "80070"
},
{
"label": "Rewritten checkEitherForwardPayload in Tact",
"pr": "https://github.com/tact-lang/jetton/pull/181",
"gas": {
"transfer": "34145",
"mint": "18842",
"burn": "12846",
"discovery": "5945",
"reportBalance": "4308",
"claimWallet": "3984"
},
"summary": "80070"
}
]
}
2 changes: 1 addition & 1 deletion src/contracts/base/jetton-wallet.tact
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ contract JettonWallet(
if (msg.responseDestination != null && msgValue > 0) {
message(MessageParameters {
to: msg.responseDestination!!,
value: msgValue,
value: 0,
mode: SendRemainingBalance + SendIgnoreErrors,
bounce: false,
body: JettonExcesses { queryId: msg.queryId }.toCell(),
Expand Down
2 changes: 1 addition & 1 deletion src/contracts/feature-rich/jetton-wallet.tact
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ contract JettonWalletFeatureRich(
if (msg.responseDestination != null && msgValue > 0) {
Copy link
Contributor

@skywardboundd skywardboundd Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be we can remove msgValue > 0

message(MessageParameters {
to: msg.responseDestination!!,
value: msgValue,
value: 0,
mode: SendRemainingBalance | SendIgnoreErrors,
bounce: false,
body: JettonExcesses { queryId: msg.queryId }.toCell(),
Expand Down
2 changes: 1 addition & 1 deletion src/contracts/governance/jetton-wallet.tact
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ contract JettonWalletGovernance(
nativeReserve(max(toLeaveOnBalance, minTonsForStorage), ReserveAtMost);
message(MessageParameters {
to: msg.responseDestination!!,
value: msgValue,
value: 0,
mode: SendRemainingBalance + SendIgnoreErrors,
bounce: false,
body: JettonExcesses { queryId: msg.queryId }.toCell(),
Expand Down