Skip to content

Conversation

AnnaRevutsky
Copy link

This PR removes the hardcoded version from the repository and replaces it with automatic versioning using setuptools_scm. This approach treats Git tags as the single source of truth for the project version, improving maintainability and consistency.

Changes include:

Added and configured setuptools_scm in pyproject.toml

Removed hardcoded version from init.py and replaced it with dynamic retrieval

Updated GitHub Actions workflow to:

Build the package with dynamic versioning

Automatically upload releases to PyPI

Issue ticket number and link (if applicable)

#38

Screenshots of the feature / bugfix

Checklist before requesting a review

  • Added relevant tests
  • Run ruff & mypy
  • All tests pass

Copy link

codecov bot commented May 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@shahar4499 shahar4499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AnnaRevutsky Thanks! :) Please resolve the conflicts and address the comments so we can merge this

pyproject.toml Outdated
Comment on lines 63 to 64
#[tool.hatch.build.targets.wheel]
#packages = ["fastapi_mcp"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this commented out? is hatch not needed anymore? if not, please remove instead of commenting out

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the formatting in your YMLs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants