-
Notifications
You must be signed in to change notification settings - Fork 851
Use setuptools_scm for dynamic versioning via Git tags #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AnnaRevutsky Thanks! :) Please resolve the conflicts and address the comments so we can merge this
pyproject.toml
Outdated
#[tool.hatch.build.targets.wheel] | ||
#packages = ["fastapi_mcp"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this commented out? is hatch not needed anymore? if not, please remove instead of commenting out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the formatting in your YMLs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done.
This PR removes the hardcoded version from the repository and replaces it with automatic versioning using setuptools_scm. This approach treats Git tags as the single source of truth for the project version, improving maintainability and consistency.
Changes include:
Added and configured setuptools_scm in pyproject.toml
Removed hardcoded version from init.py and replaced it with dynamic retrieval
Updated GitHub Actions workflow to:
Build the package with dynamic versioning
Automatically upload releases to PyPI
Issue ticket number and link (if applicable)
#38
Screenshots of the feature / bugfix
Checklist before requesting a review