Use setuptools_scm for dynamic versioning via Git tags #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
shahar4499
requested changes
Oct 15, 2025
There was a problem hiding this comment.
Hey @AnnaRevutsky Thanks! :) Please resolve the conflicts and address the comments so we can merge this
pyproject.toml
Outdated
Comment on lines
63
to
64
| #[tool.hatch.build.targets.wheel] | ||
| #packages = ["fastapi_mcp"] |
There was a problem hiding this comment.
why was this commented out? is hatch not needed anymore? if not, please remove instead of commenting out
There was a problem hiding this comment.
please fix the formatting in your YMLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the hardcoded version from the repository and replaces it with automatic versioning using setuptools_scm. This approach treats Git tags as the single source of truth for the project version, improving maintainability and consistency.
Changes include:
Added and configured setuptools_scm in pyproject.toml
Removed hardcoded version from init.py and replaced it with dynamic retrieval
Updated GitHub Actions workflow to:
Build the package with dynamic versioning
Automatically upload releases to PyPI
Issue ticket number and link (if applicable)
#38
Screenshots of the feature / bugfix
Checklist before requesting a review