Fix/hide handle mcp connection #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahar4499
requested changes
Apr 3, 2025
| @@ -155,6 +155,10 @@ def create_mcp_tools_from_openapi( | |||
| if not operation_id: | |||
| continue | |||
|
|
|||
| # Skip MCP's internal tool that doesn't follow the same patterns | |||
| if operation_id == "handle_mcp_connection_mcp_get": | |||
There was a problem hiding this comment.
@shiraayal-tadata I would instead love to understand where is the name handle_mcp_connection_mcp_get coming from in the first place, and take it from there.
That way, if the python mcp library changes the name of that function, the fix would still work.
So I suggest searching for it in the implementation of mcp sdk. Most likely we can pull it from a function's __name__ property or something like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
When creating tools from openapi_schema, skip the internal handle_mcp_connection_mcp_get
Issue ticket number and link (if applicable)
#23
Screenshots of the feature / bugfix
Before:
After:
Checklist before requesting a review