fix(openapi): handle self-referencing schemas without RecursionError (adopted from #306) - #335
Open
K4bain wants to merge 1 commit into
Open
fix(openapi): handle self-referencing schemas without RecursionError (adopted from #306)#335K4bain wants to merge 1 commit into
K4bain wants to merge 1 commit into
Conversation
resolve_schema_references() recursed infinitely when the OpenAPI schema contained a recursive Pydantic model (e.g. a filter tree referencing itself), crashing tool conversion with RecursionError. Track on the current expansion path and leave circular refs in place instead of re-resolving them. Adopted from tadata-org#306 (original patch by @mojixcoder), fixes tadata-org#287.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopted from #306 (original patch by @mojixcoder) — rebased onto current main and verified.
Why this is needed
Any FastAPI app with a recursive Pydantic model (a filter tree, a nested comment/category model, etc.) crashes convert_openapi_to_mcp_tools with RecursionError — resolve_schema_references() re-resolves the same forever (issue #287).
The fix threads a _visited frozenset of paths through the recursion: when a ref is already on the current expansion path (a cycle), it is left in place instead of being expanded again. Clients that understand (any spec-compliant MCP client) handle the cycle fine; the library just stops exploding.
Verification
Credit to @mojixcoder for the original report and patch in #306.