Skip to content

Conversation

@OlegChuev
Copy link

Added optional args as a variadic param. Not sure if it's better to use it as it is or move to the Options struct

@taigrr
Copy link
Owner

taigrr commented May 20, 2025

I'd prefer it as part of the Option struct so we don't change the function signatures. Would you be willing to make that change or should I?

@OlegChuev
Copy link
Author

I'd prefer it as part of the Option struct so we don't change the function signatures. Would you be willing to make that change or should I?

Sure, I'll take a look shortly. Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants