refactor(config-reader): cache base path resolution#3038
Merged
laststylebender14 merged 4 commits intomainfrom Apr 16, 2026
Merged
refactor(config-reader): cache base path resolution#3038laststylebender14 merged 4 commits intomainfrom
laststylebender14 merged 4 commits intomainfrom
Conversation
Co-Authored-By: ForgeCode <noreply@forgecode.dev>
Co-Authored-By: ForgeCode <noreply@forgecode.dev>
Co-Authored-By: ForgeCode <noreply@forgecode.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilize Forge config path behavior so the process uses a single consistent base directory decision for the full runtime.
Context
Config path selection influences where Forge reads and writes user settings. Recomputing that decision repeatedly in one process can introduce unnecessary variability and make behavior harder to reason about when environment state changes between calls. This change makes path resolution deterministic for the process lifetime while preserving current legacy/default fallback semantics.
Changes
base_path().Testing
cargo build -p forge_mainFORGE_LOG=debug ./target/debug/forgeFORGE_LOG=debug ./target/debug/forgecargo +nightly fmt --all && cargo +nightly clippy --all-features --workspace --all-targets --fix --allow-dirty -- -D warnings