tailscale: add fields to device data sources #574
+314
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds missing fields to the `tailscale_device` and `tailscale_devices` data sources to align with Tailscale API structure Signed-off-by: Zach Buchheit <[email protected]>
Adds last_seen nil check to deviceToMap Adds unit tests covering new data_source device fields Signed-off-by: Zach Buchheit <[email protected]>
Signed-off-by: Zach Buchheit <[email protected]>
zbuchheit
force-pushed
the
zbuchheit/add-device-fields
branch
from
859c302 to
febf427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing fields to the
tailscale_deviceandtailscale_devicesdata sources to align with Tailscale API structureWhat this PR does / why we need it:
This adds missing fields that are currently exposed in the https://tailscale.com/api#tag/devices/get/device/{deviceId} API that aren't in the tailscale_device and tailscale_devices data sources.
Special notes for your reviewer:
This does not include the
fieldsargument functionality which would exposeAdvertisedRoutes,EnabledRoutes, andClientConnectivity.Addresses #572