Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughVue template extraction now accepts attributes before or after Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The requested Vue template formats are covered by the change and its exact-output tests; no material merge-blocking issue was identified. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
2995898 to
485e278
Compare
|
@RobinMalfait Could you please take a look when you have a chance? Thanks! |
Summary
Vue files are passed through the Vue preprocessor, which detects
<template lang="pug">blocks and runs the Pug preprocessor on their contents.The existing regular expression only matched the most compact opening tag form. It missed valid Vue template tags when
langhad surrounding whitespace, when the opening tag spanned multiple lines, or when other attributes were present.This change broadens the opening-tag detection while preserving the existing body replacement behavior. Pug preprocessing now works for formatted template tags and still ignores unrelated attributes such as
data-lang.Test plan
cargo test -p tailwindcss-oxiderustfmt --check crates/oxide/src/extractor/pre_processors/vue.rsAll Oxide and scanner tests pass.