Skip to content

Update script.js #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Update script.js #15

merged 2 commits into from
Jul 12, 2024

Conversation

Imran-imtiaz48
Copy link
Contributor

Changes made:

  1. Wrapped the code in DOMContentLoaded to ensure it runs after the DOM is fully loaded.
  2. Improved variable naming for better readability (in_min, in_max, out_min, out_max to inMin, inMax, outMin, outMax).
  3. Ensured consistent indentation and formatting.
  4. Removed any unnecessary spaces and ensured concise code structure.

Imran-imtiaz48 and others added 2 commits July 9, 2024 13:10
Changes made:
1.	Wrapped the code in DOMContentLoaded to ensure it runs after the DOM is fully loaded.
2.	Improved variable naming for better readability (in_min, in_max, out_min, out_max to inMin, inMax, outMin, outMax).
3.	Ensured consistent indentation and formatting.
4.	Removed any unnecessary spaces and ensured concise code structure.
@tajulafreen
Copy link
Owner

tajulafreen commented Jul 9, 2024

Hi @Imran-imtiaz48 ,
Thanks for your contribution!

It's great to see you've taken the time to improve the code's readability and structure.

  • Wrapping the code in DOMContentLoaded ensures it runs only after the DOM is ready, which is a big plus for robustness.
  • The improved variable names are much clearer and easier to understand.
  • The consistent indentation and formatting make the code much easier to read.
  • Removing unnecessary spaces and ensuring a concise structure makes the code even more efficient.

These are all fantastic improvements.

Just one thing - I noticed the linter is throwing some errors. Could you please address those before I merge the pull request? Once those are resolved, I'll be happy to merge it in!

Kindly run this command to solve the Linter error
npx eslint . --fix

@tajulafreen tajulafreen merged commit da87291 into tajulafreen:main Jul 12, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants