IOS-5986 Validate derivation for edslip #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba1ashov
previously approved these changes
Mar 5, 2024
| @@ -93,6 +94,14 @@ class CommonUserTokensManager { | |||
| let tokenItems = converter.convertToTokenItem(nonCustomTokens) | |||
| swapAvailabilityController.loadSwapAvailability(for: tokenItems, forceReload: forceReload, userWalletId: userWalletId.stringValue) | |||
| } | |||
|
|
|||
| private func validateDerivation(for tokenItem: TokenItem) throws { | |||
There was a problem hiding this comment.
В целом был еще вот такой метод:
addTokenItemPrecondition
There was a problem hiding this comment.
возможно я по flow путаю где надо ошибку кинуть, но там метод как раз на проверки добавления
There was a problem hiding this comment.
И тогда возможно не придется тянуть throws, но throws я бы оставил конечно
There was a problem hiding this comment.
Не очень понял что ты имеешь в виду. Внутри addTokenItemPrecondition тоже вызывается validateDerivation
There was a problem hiding this comment.
Тут я сделал так, чтобы не было возможности добавить токен с неправильной деривацией, поэтому throws нужен
skibinalexander
previously approved these changes
Mar 5, 2024
|
обновил тэг и починил конфликты в подфайле |
skibinalexander
approved these changes
Mar 7, 2024
ba1ashov
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавил валидацию деривации для edslip. В идеале надо валидировать инпут, но это уже можно будет сделать отдельно на новом кастом менедж токенс, если захочется. Сейчас закрываю такую возможность на более низком уровне
TODO: поднять тэг сдк с игнорированием ошибок tangem/tangem-sdk-ios#341