fix(tangle-dapp): Payouts v2 #2833
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devpavan04
requested review from
AtelyPham,
yurixander and
monaiuu
as code owners
✅ Deploy Preview for tangle-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for tangle-cloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4 tasks
drewstone
reviewed
Feb 19, 2025
drewstone
reviewed
Feb 19, 2025
|
Display preview testing does not work for me @devpavan04 |
drewstone
reviewed
Feb 20, 2025
| const identity = await api.derive.accounts.info(validatorAddress); | ||
| validatorIdentities.set( | ||
| validatorAddress, | ||
| identity.identity.display?.toString() || '', |
There was a problem hiding this comment.
Don't confuse empty identity with no identity.
drewstone
reviewed
Feb 20, 2025
| eras: eras, | ||
| validator: { | ||
| address: assertSubstrateAddress(validatorAddress), | ||
| identity: validatorIdentities.get(validatorAddress) || '', |
There was a problem hiding this comment.
Same here, don't confuse empty identity with no identity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Provide a detailed description of proposed changes.
Proposed area of change
Put an
xin the boxes that apply.apps/tangle-dappapps/tangle-cloudlibs/tangle-shared-uilibs/ui-componentsAssociated issue(s)
Specify any issues that can be closed from these changes (e.g.
Closes #233).Screen Recording
If possible provide screenshots and/or a screen recording of proposed change.