Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tangle-dapp): Fix token selector not working for Tangle mainnet #2849

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

devpavan04
Copy link
Member

@devpavan04 devpavan04 commented Feb 26, 2025

Summary of changes

Proposed area of change

  • apps/tangle-dapp
  • apps/tangle-cloud
  • libs/tangle-shared-ui
  • libs/ui-components

Associated issue(s)

Screen Recording

CleanShot.2025-02-28.at.06.34.18.mp4

Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit 11994c3
🔍 Latest deploy log https://app.netlify.com/sites/tangle-cloud/deploys/67c253544fa7890008217115
😎 Deploy Preview https://deploy-preview-2849--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit 11994c3
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/67c253542ab5cd0008dbe463
😎 Deploy Preview https://deploy-preview-2849--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@devpavan04 devpavan04 marked this pull request as draft February 26, 2025 18:21
@devpavan04 devpavan04 marked this pull request as ready for review February 28, 2025 14:35
Copy link
Member

@AtelyPham AtelyPham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

)?.balance;
const balance =
isNativeToken && token.tokenType === 'TNT'
? formatEther(nativeTokenBalance?.value ?? BigInt(0))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nativeTokenBalance?.value !== undefined
	? formatEther(nativeTokenBalance.value) 
	: undefined

@@ -426,18 +426,19 @@ const BridgeContainer = ({ className }: Props) => {

const assets: AssetConfig[] = useMemo(() => {
return tokens.map((token) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utilize AI to refactor this assets calculation memo for better readability and easier review.

@devpavan04 devpavan04 marked this pull request as draft February 28, 2025 21:55
@devpavan04 devpavan04 marked this pull request as ready for review March 1, 2025 00:24
@devpavan04 devpavan04 requested a review from AtelyPham March 1, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Asset selection doesn't work on bridge
2 participants