Skip to content

test: add benchmarks #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test: add benchmarks #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/testing.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,18 @@ jobs:
run: make coverage coveralls-deps coveralls

run-benchmarks:
if: false
if: (github.event_name == 'push') ||
(github.event_name == 'pull_request' &&
github.event.pull_request.head.repo.full_name != github.repository) ||
(github.event_name == 'workflow_dispatch')

runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
golang: ['1.24', 'stable']

steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
Expand Down
5 changes: 5 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ testrace:
@echo "Running tests with race flag"
@go test ./... -count=100 -race

.PHONY: bench
bench:
@echo "Running benchmarks"
@go test ./... -count=1 -bench=. -benchmem
Copy link
Collaborator

@oleg-jukovec oleg-jukovec Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need the benchmem? If so - ok.

Copy link
Collaborator

@bigbes bigbes Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-benchmem will show allocation count, I think it's necessary information for us to use.

Copy link
Author

@elhimov elhimov Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are interested in number of allocation and this option displays allocation statistic.


.PHONY: coverage
coverage:
@echo "Running tests with coveralls"
Expand Down
Loading
Loading