fix(job-scheduler): consider removing current job from wait, paused or prioritized #3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
changed the title
roggervalf
force-pushed
the
fix-js-remove-current-job
branch
7 times, most recently
from
e26d0fe to
196e055
Compare
roggervalf
force-pushed
the
fix-js-remove-current-job
branch
from
196e055 to
b897552
Compare
roggervalf
force-pushed
the
fix-js-remove-current-job
branch
from
b897552 to
5998c7a
Compare
manast
reviewed
Feb 21, 2025
| @@ -4,6 +4,10 @@ | |||
| Input: | |||
| KEYS[1] 'repeat' key | |||
| KEYS[2] 'delayed' key | |||
| KEYS[3] 'wait' key | |||
| KEYS[4] 'paused' key | |||
There was a problem hiding this comment.
We do not have pause key anymore, so why is this key needed?
| rcall("ZREM", prioritizedKey, currentJobId) | ||
| else | ||
| if isQueuePaused(KEYS[5]) then | ||
| if rcall("LREM", KEYS[4], 1, currentJobId) > 0 then |
There was a problem hiding this comment.
This should not be needed as there is no pause key.
manast
approved these changes
Feb 21, 2025
It's being removed as part of next breaking change #2707 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 21, 2025
## [5.41.5](v5.41.4...v5.41.5) (2025-02-21) ### Bug Fixes * **job-scheduler:** consider removing current job from wait, paused or prioritized ([#3066](#3066)) ([97cd2b1](97cd2b1))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
Additional Notes (Optional)
Any extra info here.