fix(scheduler): remove multi when updating a job scheduler #3108
+143
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
force-pushed
the
update-scheduler
branch
2 times, most recently
from
74dd9b1 to
a348c27
Compare
manast
reviewed
Mar 3, 2025
| --- @include "isQueuePaused" | ||
| --- @include "storeJob" | ||
|
|
||
| local function addJobFromScheduler(jobKey, jobId, rawOpts, waitKey, pausedKey, metaKey, prioritizedKey, |
There was a problem hiding this comment.
In time we will need to figure out some way to reduce the amount of arguments passed to this utility functions.
| @@ -43,19 +51,16 @@ local prevMillis = rcall("ZSCORE", repeatKey, jobSchedulerId) | |||
| if prevMillis ~= false then | |||
| local currentDelayedJobId = "repeat:" .. jobSchedulerId .. ":" .. prevMillis | |||
|
|
|||
| if producerId == currentDelayedJobId then | |||
| if producerId == currentDelayedJobId and rcall("EXISTS", nextDelayedJobKey) ~= 1 then | |||
There was a problem hiding this comment.
This seems to be new code "and rcall("EXISTS", nextDelayedJobKey) ~= 1" not sure which issue it fixes but It would be nice with a test case that proves it is needed.
There was a problem hiding this comment.
actually this checks is already in our currently job. When adding a delayed job in a separeted script, we check that it's not duplicated. Same logic is added here.
manast
approved these changes
Mar 11, 2025
roggervalf
force-pushed
the
update-scheduler
branch
from
a348c27 to
c4287db
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Mar 11, 2025
## [5.41.9](v5.41.8...v5.41.9) (2025-03-11) ### Bug Fixes * **scheduler:** remove multi when updating a job scheduler ([#3108](#3108)) ([4b619ca](4b619ca))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
Additional Notes (Optional)
Any extra info here.