perf(worker): optimize job retrieval for failed jobs in chunks #3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Weird, tests fail… I'll check it out later today. |
|
@roggervalf it seems this PR introduces new flakiness in some unrelated tests, we need to decide if merging it as is or trying to find the root cause. |
it seems that they are unrelated to this change |
roggervalf
force-pushed
the
move-stalled-jobs-to-wait-performance
branch
from
2508229 to
de80f1e
Compare
roggervalf
force-pushed
the
move-stalled-jobs-to-wait-performance
branch
from
de80f1e to
c073942
Compare
roggervalf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The current implementation of
moveStalledJobsToWaitprocesses failed jobs by making individualJob.fromIdcalls within a loop. This can lead to performance bottlenecks when dealing with many stalled jobs, as each job requires a separate Redis operation.This change is necessary to:
How