Skip to content

remove token for oidc token publishing #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
+5 −4
Open

remove token for oidc token publishing #934

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/publish-napi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

name: publish napi modules

permissions:
# required for OIDC token
id-token: write

env:
DEBUG: napi:*
APP_NAME: create-tauri-app
Expand Down Expand Up @@ -210,7 +214,7 @@ jobs:
npm i -g --force corepack
corepack enable
- name: Setup node
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: 20
cache: pnpm
Expand All @@ -236,12 +240,9 @@ jobs:

- name: Publish
run: |
echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" >> ~/.npmrc
npm publish
Copy link
Member Author

@jbolda jbolda Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amrbashir I don't understand the reason that we were calling publish twice. Any recollection?

Copy link
Member

@amrbashir amrbashir Nov 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are releasing two packages here, create-tauri-app and create-tauri

this way users can do pnpm create tauri or pnpm create tauri-app but iirc the primary reason was to squat create-tauri and avoid having it fall in the hands of a malicious squatter.

jq '.name = "create-tauri" | .bin = { "create-tauri": .bin["create-tauri-app"] } | del(.scripts.prepublishOnly)' package.json > package.tmp
mv -f package.tmp package.json
npm publish
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.ORG_NPM_TOKEN }}
RELEASE_ID: ${{ github.event.client_payload.releaseId || inputs.releaseId }}