fix(http): fix aborting a streaming response#2562
Merged
FabianLars merged 5 commits intov2from Nov 24, 2025
Merged
Conversation
Contributor
Package Changes Through 30499bbThere are 4 changes which include http with patch, http-js with patch, updater with minor, updater-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
sxzz
approved these changes
Oct 21, 2025
FabianLars
approved these changes
Nov 3, 2025
Member
FabianLars
left a comment
FabianLars
left a comment
There was a problem hiding this comment.
I also only really tested this #2557 (comment)
Comment on lines
+424
to
+430
| // SAFETY: we can access the inner value mutably | ||
| // because we are the only ones with a reference to it | ||
| // and we don't want to use `Arc::into_inner` because we want to keep the value in the table | ||
| // for potential future calls to `fetch_cancel_body` | ||
| let res_ptr = Arc::as_ptr(&res) as *mut ReqwestResponse; | ||
| let res = unsafe { &mut *res_ptr }; | ||
| let res = &mut res.0; |
Member
There was a problem hiding this comment.
this still sounds pretty risky to me
This comment was marked as resolved.
This comment was marked as resolved.
|
It's my mistake,to adapt this pr,specify the frontend JS API is neeed: "@tauri-apps/plugin-http": "github:tauri-apps/tauri-plugin-http",without above and simply set below will broken😢 [dependencies.tauri-plugin-http]
git = "ssh://git@github.com/tauri-apps/plugins-workspace.git"
branch = "v2" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2557