Support emitting traces behind feature flag#2576
Merged
Legend-Master merged 17 commits intotauri-apps:v2from Apr 7, 2025
Merged
Support emitting traces behind feature flag#2576Legend-Master merged 17 commits intotauri-apps:v2from
Legend-Master merged 17 commits intotauri-apps:v2from
Conversation
Contributor
Package Changes Through 4a434d8There are 12 changes which include autostart with minor, autostart-js with minor, http with patch, http-js with patch, deep-link with patch, deep-link-js with patch, log with minor, log-js with minor, fs with patch, fs-js with patch, updater with minor, updater-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Legend-Master
approved these changes
Apr 7, 2025
Contributor
|
I'm not the most familiar with tracing but it looks good to me in general, and since it doesn't affect existing code anyways, this is a good start, I'll merge it Nice work, thanks! |
gezihuzi
pushed a commit
to Hypobenthos/plugins-workspace
that referenced
this pull request
Jun 22, 2025
* Let logging be skippable so user can handle logger() * Add changes file * changes meta info * Update documentation * Support emitting to tracing behind feature flag * typo * rename key_values => kv * changes file * Remove rebase skip-logger * fix format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description:
This PR adds an optional "tracing" feature that will emit log messages to
tracing. It does not affect current logging. To keep things simple, by enabling the feature, you're opting into emitting totracing. This was to avoid adding state to the Tauri app on behalf of the plugin that would hold some sort of "is_using_tracing" value.Problem it's addressing
To currently leverage tracing without this PR, applications must call
skip_logger()and setup of thetracing-loglogger themselves. This is overall fine. However, I was encountering issues with thetracing-logcrate on iOS so wanted to a way to avoid the bridge. Additionally, since I only use tracing myself within my code, I only had the adapter to support this plugin and therefore this feature removes that requirement.So overall, this PR would support:
skip_logger()which would nop on the logger invocation and emit the trace.Implementation is fairly basic in order to avoid unnecessary complexity. Please let me know if you have any feedback.