fix(macos): forward unhandled keyDown events to WebView content#1711
Open
AprilNEA wants to merge 1 commit into
Open
fix(macos): forward unhandled keyDown events to WebView content#1711AprilNEA wants to merge 1 commit into
AprilNEA wants to merge 1 commit into
Conversation
Contributor
Package Changes Through bcd1493No changes. Add a change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On macOS,
WryWebViewParent::keyDown:unconditionally sends all key events tomenu.performKeyEquivalent()without checking the return value or forwarding unhandled events. This causes bare key presses (numbers, symbols, arrow keys) to be silently swallowed — they never reach the WKWebView content, especially in iframe-based applications.Changes
performKeyEquivalentwhen Command or Control modifiers are heldperformKeyEquivalentreturn value — if the menu handled it, stop; otherwise fall throughinterpretKeyEvents(notsuper.keyDown) to avoid re-introducing the NSBeep sound fixed in PR fix(macos): do not trigger unsupported key feedback sound on keypress #742Background
interpretKeyEventsto suppress beepperformKeyEquivalentfor menu shortcutsperformKeyEquivalentwithout return value check — current buggy stateKnown limitation
This does not fix Cmd+key JavaScript listeners in child webviews (the existing FIXME in
wry_web_view.rs:47-50). That is a separate issue tracked in #1177.Fixes #1175
Refs #1177, #801