fix(macos): handle nil NSOpenPanel in run_file_upload_panel#1716
Open
MrSaturn1 wants to merge 1 commit into
Open
fix(macos): handle nil NSOpenPanel in run_file_upload_panel#1716MrSaturn1 wants to merge 1 commit into
MrSaturn1 wants to merge 1 commit into
Conversation
Contributor
Package Changes Through 0fb3d76There are 1 changes which include wry with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
pewsheen
previously approved these changes
Apr 24, 2026
Contributor
pewsheen
left a comment
pewsheen
left a comment
There was a problem hiding this comment.
Thank you!
Could you sign your commit and add a change file to .changes/?
NSOpenPanel::openPanel() can return nil in rare edge cases on macOS (code-signature mismatch after in-place update, system wake transient). The typed objc2 binding panics on nil, crashing the app. Use raw msg_send + Retained::retain to detect nil and gracefully cancel the file picker by calling the WebKit completion handler with null. Fixes tauri-apps/tauri#13047
MrSaturn1
force-pushed
the
fix-nsopenpanel-nil
branch
from
782bea9 to
0fb3d76
Compare
pewsheen
approved these changes
Apr 25, 2026
Contributor
|
Hmm,lLooks like you'll need to upload your public signing key to GitHub, otherwise the commit will remain unverified. |
|
Thanks @MrSaturn1!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NSOpenPanel::openPanel() can return nil in rare macOS edge cases (code-signature mismatch after in-place app update, system wake transient). The typed objc2 binding panics on nil, crashing the app.
Use raw msg_send + Retained::retain to detect nil and gracefully cancel the file picker by calling the WebKit completion handler with null.
Fixes tauri-apps/tauri#13047