Conversation
spec.emu: - Use Table 70 lookup for receiver validation instead of [[TypedArrayName]] slot - Add explicit GetMethod/undefined check for items iterator (all 3 methods) - Add IsTypedArrayOutOfBounds re-check in %TypedArray%.concat copy loop - Use "integral Number" concept in ValidateIntegralNumber (replaces NaN + truncate checks) - Use ArrayBufferByteLength() AO in CopySourcesToBuffer (not raw slot access) - Restructure options handling: remove OrdinaryObjectCreate(null), use if/else - Add type="built-in function" to all 3 concat clauses - Add "length" property definitions for all 3 methods - Add NOTE about detachment safety in CopySourcesToBuffer - Add NOTE about empty iterable edge case in %TypedArray%.concat - Add Assert that MakeArrayBufferImmutable is not called on SharedArrayBuffer - Add "It performs the following steps when called:" to AO descriptions TEST_CASES.md: - Fix [9.2.4]: null options is TypeError (not accepted) - Fix [25.6.1]: subclass constructors not in Table 70, clear TypeError - Fix section 1.2 heading to reference Table 70 - Add Symbol.iterator=null tests for all 3 methods - Add null options test for SharedArrayBuffer.concat - Clean up evaluation order section with correct step references
|
The rendered spec for this PR is available at https://tc39.es/proposal-typedarray-concat/pr/9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spec.emu:
TEST_CASES.md: