Update README.md to use github.sha instead of github.ref#143
Open
Jamesking56 wants to merge 1 commit intotclindner:masterfrom
Open
Update README.md to use github.sha instead of github.ref#143Jamesking56 wants to merge 1 commit intotclindner:masterfrom
Jamesking56 wants to merge 1 commit intotclindner:masterfrom
Conversation
Owner
|
Hey @Jamesking56 does our current comment/note cover this already?
|
Author
|
The comment is good however the main example of using I'd rather the default examples are working as a straight drop-in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#48 (comment)
This comment says its better to use
github.sharather thangithub.refso we should really tell people to start with that in the Readme.