fix: add Folly configuration for RN 0.77-0.79 with static frameworks - #1
Closed
Mohamed-kassim wants to merge 1 commit into
Closed
fix: add Folly configuration for RN 0.77-0.79 with static frameworks#1Mohamed-kassim wants to merge 1 commit into
Mohamed-kassim wants to merge 1 commit into
Conversation
Fixes build failures when using use_frameworks! :linkage => :static (often required for Firebase integration) on React Native 0.77-0.79. The build errors encountered: - 'folly/folly-config.h' file not found - Could not build module 'NitroModules' - Could not build module 'jsi' This adds pod_target_xcconfig with: - Header search paths for RCT-Folly - Preprocessor definitions for FOLLY_NO_CONFIG and FOLLY_CFG_NO_COROUTINES - C++ compiler flags for Folly mobile configuration Reference: mrousavy/nitro#825
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes build failures when using
use_frameworks! :linkage => :static(often required for Firebase integration) on React Native 0.77-0.79.The build errors encountered:
Changes
Adds
pod_target_xcconfigwith:FOLLY_NO_CONFIGandFOLLY_CFG_NO_COROUTINESReference