Fix unreachable inner if condition #3282
Open
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The outer condition checks if op is one of
"sclpsv", "sclpsp" or "sclpsd"
where the inner condition checks against"sclsv" and "sclsp"
.Enums will be a great choice here, as the code grows you have to keep track of the exact string option. However, you may also consider using a static analysis tool such as Cppcheck to detect issues like this. You might also integrate it into a CI workflow for automated checks.
Have a great day!