Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unreachable inner if condition #3282

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

baderouaich
Copy link

The outer condition checks if op is one of "sclpsv", "sclpsp" or "sclpsd" where the inner condition checks against "sclsv" and "sclsp".

Enums will be a great choice here, as the code grows you have to keep track of the exact string option. However, you may also consider using a static analysis tool such as Cppcheck to detect issues like this. You might also integrate it into a CI workflow for automated checks.

Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant