Conversation
jkleiber
left a comment
jkleiber
left a comment
There was a problem hiding this comment.
This is really cool! I left some comments but I think the structure is what we would want
|
@minhnguyenbhs this looks good to me. Before approving/merging, I'd like us to update the branch and test this on the robot |
| break; | ||
| default: | ||
| t = null; | ||
| break; |
There was a problem hiding this comment.
Hey this is a bit of a nitpick but can you send a warning through the driver station and set an empty trigger when a non-existent button is configured? I would rather not have to null-check button assignments in RobotContainer or risk crashing over a heat-of-the-moment typo.
| break; | ||
| default: | ||
| t = null; | ||
| break; |
|
|
||
| if (controllers.get(p.get("controller")) == null) { | ||
| povList.put((String) p.get("command"), () -> 0); | ||
| } else |
There was a problem hiding this comment.
...and add a warning here.
There was a problem hiding this comment.
Okay! I'll fix this as soon as possible! Is the robot ready yet?
There was a problem hiding this comment.
We should get it on Saturday
… verify that everything else is actually correct :D
BlueCricket6
force-pushed
the
json-config
branch
from
4c4f570 to
81540e5
Compare
5 participants
I haven't tested it out with an actual gamepad yet, but it appears to be working with simulation joysticks maybe? I'll get to the rest of the testing stuff on Wednesday, but in the meantime what do you think about the layout and everything?