Skip to content

PAC-950 Add compatibility with PHP 8.4 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svizevv merged 2 commits into from
Oct 24, 2025
Merged

PAC-950 Add compatibility with PHP 8.4 #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3eed242
PAC-950 Add compatibility with PHP 8.4
svizevv Sep 18, 2025
90528d5
PAC-950 Update dependencies
svizevv Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
# Version 26.1.0

## Features

### PHP 8.4 Compatibility

* Add PHP 8.4 support

# Version 26.0.1

## Bugfixes
Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"license": "MIT",
"require": {
"php": "^8.1",
"techdivision/import-product": "^26.0.0"
"techdivision/import-product": "^26.2"
},
"require-dev": {
"doctrine/dbal": "^4.0.4",
Expand Down Expand Up @@ -40,4 +40,4 @@
]
}
}
}
}
2 changes: 1 addition & 1 deletion src/Callbacks/BundlePriceViewCallback.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class BundlePriceViewCallback extends AbstractProductImportCallback
*
* @return mixed The modified value
*/
public function handle(AttributeCodeAndValueAwareObserverInterface $observer = null)
public function handle(?AttributeCodeAndValueAwareObserverInterface $observer = null)
{

// set the observer
Expand Down
2 changes: 1 addition & 1 deletion src/Callbacks/BundleShipmentTypeCallback.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class BundleShipmentTypeCallback extends AbstractProductImportCallback
*
* @return mixed The modified value
*/
public function handle(AttributeCodeAndValueAwareObserverInterface $observer = null)
public function handle(?AttributeCodeAndValueAwareObserverInterface $observer = null)
{

// set the observer
Expand Down
2 changes: 1 addition & 1 deletion src/Callbacks/BundleTypeCallback.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class BundleTypeCallback extends AbstractProductImportCallback
*
* @return mixed The modified value
*/
public function handle(AttributeCodeAndValueAwareObserverInterface $observer = null)
public function handle(?AttributeCodeAndValueAwareObserverInterface $observer = null)
{

// set the observer
Expand Down
8 changes: 4 additions & 4 deletions src/Observers/BundleOptionObserver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,14 @@ class BundleOptionObserver extends AbstractProductImportObserver implements Dyna
*
* @param \TechDivision\Import\Product\Bundle\Services\ProductBundleProcessorInterface $productBundleProcessor The product bundle processor instance
* @param \TechDivision\Import\Observers\AttributeLoaderInterface|null $attributeLoader The attribute loader instance
* @param \TechDivision\Import\Observers\EntityMergers\EntityMergerInterface $entityMerger The entity merger instance
* @param \TechDivision\Import\Observers\EntityMergers\EntityMergerInterface|null $entityMerger The entity merger instance
* @param \TechDivision\Import\Observers\StateDetectorInterface|null $stateDetector The state detector instance
*/
public function __construct(
ProductBundleProcessorInterface $productBundleProcessor,
AttributeLoaderInterface $attributeLoader = null,
EntityMergerInterface $entityMerger = null,
StateDetectorInterface $stateDetector = null
?AttributeLoaderInterface $attributeLoader = null,
?EntityMergerInterface $entityMerger = null,
?StateDetectorInterface $stateDetector = null
) {

// initialize the product bundle processor, the attribute loader and entity merger instance
Expand Down
8 changes: 4 additions & 4 deletions src/Observers/BundleSelectionObserver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,14 @@ class BundleSelectionObserver extends AbstractProductImportObserver implements D
*
* @param \TechDivision\Import\Product\Bundle\Services\ProductBundleProcessorInterface $productBundleProcessor The product bundle processor instance
* @param \TechDivision\Import\Observers\AttributeLoaderInterface|null $attributeLoader The attribute loader instance
* @param \TechDivision\Import\Observers\EntityMergers\EntityMergerInterface $entityMerger The entity merger instance
* @param \TechDivision\Import\Observers\EntityMergers\EntityMergerInterface|null $entityMerger The entity merger instance
* @param \TechDivision\Import\Observers\StateDetectorInterface|null $stateDetector The state detector instance
*/
public function __construct(
ProductBundleProcessorInterface $productBundleProcessor,
AttributeLoaderInterface $attributeLoader = null,
EntityMergerInterface $entityMerger = null,
StateDetectorInterface $stateDetector = null
?AttributeLoaderInterface $attributeLoader = null,
?EntityMergerInterface $entityMerger = null,
?StateDetectorInterface $stateDetector = null
) {

// initialize the product bundle processor and the attribute loader instance
Expand Down
Loading