Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BASE_IMAGE parameter to s2i-python #2397

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add BASE_IMAGE parameter to s2i-python #2397

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acec3b6
Add BASE_IMAGE parameter to s2i-python
sveno1990 Nov 7, 2024
d9e9247
Fix default
sveno1990 Nov 11, 2024
5406e20
Merge branch 'tektoncd:main' into feature/s2i-python-base-image-param…
sveno1990 Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...r/kodata/tekton-addon/addons/02-clustertasks/source_local/s2i-python/s2i-python-task.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ spec:
type: array
description: Environment variables to set during _build-time_.
default: []
- name: BASE_IMAGE
type: string
description: The location of the base python image.
default: image-registry.openshift-image-registry.svc:5000/openshift/python
workspaces:
- name: source
mountPath: /workspace/source
Expand All @@ -65,7 +69,7 @@ spec:
echo "$var" >> /env-vars/env-file
done

s2i build $(params.PATH_CONTEXT) image-registry.openshift-image-registry.svc:5000/openshift/python:$(params.VERSION) \
s2i build $(params.PATH_CONTEXT) $(params.BASE_IMAGE):$(params.VERSION) \
--as-dockerfile /gen-source/Dockerfile.gen --environment-file /env-vars/env-file
volumeMounts:
- name: gen-source
Expand Down