Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add stepaction as a valid kind in the hub resolver #8635

Merged
merged 1 commit into from
Apr 1, 2025
Merged

fix: add stepaction as a valid kind in the hub resolver #8635

merged 1 commit into from
Apr 1, 2025

Conversation

waveywaves
Copy link
Member

@waveywaves waveywaves commented Mar 11, 2025 •
edited
Loading

Changes

fixes #8634

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

the hub resolver now validates StepActions as a valid kind

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2025
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Mar 11, 2025
@waveywaves
Copy link
Member Author

/kind bug

@tekton-robot tekton-robot added kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2025
@waveywaves waveywaves force-pushed the step-action-artifact-hub-resolution branch from 5c8232f to 5bc1e64 Compare March 11, 2025 13:44
aThorp96
aThorp96 approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@aThorp96 aThorp96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional suggestion. Looks good to me though!

pkg/resolution/resolver/hub/resolver.go Outdated
Comment on lines 362 to 363
if kind != "task" && kind != "pipeline" && kind != "stepaction" {
return errors.New("kind param must be either a task, pipeline or a stepaction")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional suggestion: I like they way this was addressed in the Cluster Resolver, with a const list of supportedKinds. Any objection to following that pattern?

vdemeester
vdemeester approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @aThorp96 but it could be done in a follow-up as well.
cc @afrittoli

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2025
@waveywaves waveywaves force-pushed the step-action-artifact-hub-resolution branch 2 times, most recently from 8ee6b90 to 4419884 Compare March 20, 2025 10:02
@vdemeester
Copy link
Member

/retest

@waveywaves waveywaves force-pushed the step-action-artifact-hub-resolution branch from 4419884 to 837f7c4 Compare March 28, 2025 23:15
@waveywaves
fix: add stepaction as a valid kind in the hub resolver
41ff747 
The hub resolver should consider StepAction as a valid kind.
This change ensures that the controller considers a stepaction as a valid kind
resolving through a hub resolver.

test: validate step actions in hub resolver
@waveywaves waveywaves force-pushed the step-action-artifact-hub-resolution branch from 837f7c4 to 41ff747 Compare March 28, 2025 23:21
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/resolution/resolver/hub/resolver.go 77.5% 77.6% 0.1

@waveywaves
Copy link
Member Author

@aThorp96 @vdemeester I have added a list of supported types as you suggested, should be good to merge but let me know if there is anything else to add

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aThorp96, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aThorp96
Copy link
Contributor

/lgtm

@tekton-robot
Copy link
Collaborator

@aThorp96: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2025
@tekton-robot tekton-robot merged commit 3741719 into tektoncd:main Apr 1, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Tekton Community Roadmap Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@aThorp96 aThorp96 aThorp96 approved these changes

@jerop jerop Awaiting requested review from jerop

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Tekton Community Roadmap
Status: Done
Milestone
Pipeline v1.0.0
Development

Successfully merging this pull request may close these issues.

bug: stepaction with artifacthub resolver fails on validation
4 participants
@waveywaves @vdemeester @tekton-robot @aThorp96