Vhost parameter added. by sromerotech · Pull Request #527 · telefonicaid/iotagent-json

sromerotech · 2021-02-06T20:28:23Z

I've added the vhost parameter so you can customize it. I'll appreciate any feedback on this PR. Thanks in advance.

AlvaroVega · 2021-02-08T07:23:18Z

Thaks for your contribution @sergiorb !
Could you add some documentation about new parameter IOTA_AMQP_VHOST in https://github.com/telefonicaid/iotagent-json/blob/master/docs/installationguide.md#amqp-binding-configuration?

CHANGES_NEXT_RELEASE

AlvaroVega · 2021-02-08T11:03:36Z

LGTM
A twin PR for iota-ul is expected

Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>

AlvaroVega

LGTM

sromerotech · 2021-03-21T19:53:10Z

Hello @AlvaroVega @fgalan and sorry for the delay. I've updated the branch with some test that needs a specially set-up RabbitMQ to run due to the creation of the virtual host is not possible from the amqplib library. May you check that out? I'll replicate the changes in Iotagent-ul repo as soon as you validate this one. Thanks in advance.

README.md

fgalan · 2021-03-22T12:20:57Z

test/unit/amqpBinding-test3.js

@@ -0,0 +1,223 @@
+/*


instead of -test3.js it would be better a more meaningful suffix, according to the kind of test cases included in this file.

Maybe test/unit/amqpBinding-vhost-test.js ?

Nice! I just followed what I found there. Name it as you like.

Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>

fgalan · 2021-03-22T12:28:17Z

test/unit/amqpBinding-vhost-test.js.js

@@ -0,0 +1,223 @@
+/*


test/unit/amqpBinding-vhost-test.js.js -> test/unit/amqpBinding-vhost-test.js

Too much "js" at the end ;)

fgalan · 2021-03-23T16:08:13Z

LGTM. Thanks!

We will merge once you can address the following, please:

Fix the CHANGES_NEXT_RELASE little conflict existing now
Sync the changes in the twin PR in IOTA-UL (Vhost parameter added. iotagent-ul#462)

With regards to README.md, maybe we will do some refactor of the documentation of your contribution but with regards this PR is fine.

fgalan · 2021-03-26T10:35:50Z

CHANGES_NEXT_RELEASE

- Fix: avoid raise mongo alarm when a measure is not maching a group configuration
- Upgrade NodeJS version from 10 to 12 in Dockerfile due to Node 10 End-of-Life
- Set Nodejs 12 as minimum version in packages.json (effectively removing Nodev10 from supported versions)
- Add list of environment variables which can be protected by Docker Secrets
+- Fix: avoid raise mongo alarm when a measure is not maching a group configuration
+- Fix: Set 60 seconds for default mqtt keepalive option (#413)
+- Upgrade NodeJS version from 10 to 12 in Dockerfile due to Node 10 End-of-Life
+- Set Nodejs 12 as minimum version in packages.json (effectively removing Nodev10 from supported versions)
+- Add: Support of multimeasure for MQTT and AMQP transport (#462)
+- Add: virtual host configuration added to AMQP transport (config.amqp.vhost and IOTA_AMQP_VHOST env var)
+- Add list of environment variables which can be protected by Docker Secrets


Not sure if the conflict in CHANGES_NEXT_RELEASE has been correctly solved...

CHANGES_NEXT_RELEASE at this PR branch should contain the current entries in master (i.e. https://github.com/telefonicaid/iotagent-json/blob/master/CHANGES_NEXT_RELEASE) plus the line associated to this PR (i.e. - Add: virtual host configuration added to AMQP transport (config.amqp.vhost and IOTA_AMQP_VHOST env var)).

sromerotech · 2021-03-26T10:55:09Z

Hello @fgalan and thank you for your feedback. I've updated the CHANGES_NEXT_RELEASE file as requested and also updated README.md with a more concise note about the RabbitMQ configuration. Notice that rabbitmq:management is necessary for the test to pass.
I also have pushed these changes to the telefonicaid/iotagent-ul#462 PR.

fgalan · 2021-03-26T14:33:05Z

Could you have a look to the tests run in GitActions, please? It seems many of them are failing...

sromerotech · 2021-03-29T12:16:36Z

Could you have a look to the tests run in GitActions, please? It seems many of them are failing...

I've been working on them and I cannot find a way to mount the definitions file as volume without breaking the pipeline. It seems that Git checkout step tries to delete all files, being unable to delete de mounted definition. I've opened a PR in rabbitmq-github-action in order to remove rabbitmq service and add that action as a step before running the test.

On the other hand, I've run master-branch's tests locally and they fail too, mainly due to ContextBroker issues. Could you take a look on that?

Thanks.

fgalan · 2021-03-29T14:59:45Z

On the other hand, I've ran master-branch's tests locally and they fail too, mainly due to ContextBroker issues. Could you take a look on that?

Nos sure what do you mean... according to github, test are passing ok in master at the present moment:

fgalan · 2021-04-09T11:50:06Z

Nos sure what do you mean... according to github, test are passing ok in master at the present moment:

After careful examination, this is not fully true... The tests were ok in master when I look at it (the screenshot is correct) but I have re-run the tests in master and they have failed. This may be caused due to two reasons:

Changes not in the IOTA code itself but in a "open dependency" (i.e. dependency in packages.json that points to a branch instead of a version number of commit). At the present moment, I think iotagent-node-lib is the only dependency of this kind
Changes in GitHub Actions (although I don't figure out which one could be...)

We are analyzing it.

CC: @AlvaroVega

fgalan · 2021-04-13T09:10:52Z

Nos sure what do you mean... according to github, test are passing ok in master at the present moment:

After careful examination, this is not fully true... The tests were ok in master when I look at it (the screenshot is correct) but I have re-run the tests in master and they have failed. This may be caused due to two reasons:

Changes not in the IOTA code itself but in a "open dependency" (i.e. dependency in packages.json that points to a branch instead of a version number of commit). At the present moment, I think iotagent-node-lib is the only dependency of this kind

Changes in GitHub Actions (although I don't figure out which one could be...)

We are analyzing it.

CC: @AlvaroVega

At the end, it was due to iotagent-node-lib. Some changes on that library make some test to be "unaligned". It has been already fixed in master (by PR #550).

Thus, could you please update this PR brach con master. After that I guess that all your changes in ci.yml in this PR are not needed and can be reverted. Remember also to remove packages-lock.json from the PR. Thanks!

fgalan · 2024-05-13T07:42:02Z

@sromerotech could you explain why this PR has been closed, please? Do you plan to re-create it? Thanks!

Sergio Romero Barra added 2 commits February 6, 2021 21:25

Vhost parameter added.

3ef71d4

Test fixed.

252fc0c

Docs updated. Changelog updated.

25a73a4

fgalan reviewed Feb 8, 2021

View reviewed changes

CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved

Update CHANGES_NEXT_RELEASE

7112351

Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>

AlvaroVega approved these changes Feb 15, 2021

View reviewed changes

fgalan mentioned this pull request Feb 16, 2021

Vhost parameter added. telefonicaid/iotagent-ul#462

Closed

Tests updated.

d098d51

fgalan reviewed Mar 22, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

fgalan reviewed Mar 22, 2021

View reviewed changes

sromerotech and others added 2 commits March 22, 2021 13:24

Update README.md

6b0da23

Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>

Amqp vhost test file renamed.

21349cf

fgalan reviewed Mar 22, 2021

View reviewed changes

File type fixed.

7220807

Merge branch 'master' into amqp-vhost

6946e2a

fgalan reviewed Mar 26, 2021

View reviewed changes

Sergio Romero Barra added 2 commits March 26, 2021 11:36

Docks updated.

06a1439

updated CHANGES_NEXT_RELEASE as requested.

c357b78

CI updated.

a6704e1

Now, CI uses rabbitmq-github-action instead of service.

9841ad4

sromerotech closed this by deleting the head repository May 11, 2024

Conversation

sromerotech commented Feb 6, 2021

Uh oh!

AlvaroVega commented Feb 8, 2021

Uh oh!

Uh oh!

AlvaroVega commented Feb 8, 2021

Uh oh!

AlvaroVega left a comment

Choose a reason for hiding this comment

Uh oh!

sromerotech commented Mar 21, 2021

Uh oh!

Uh oh!

fgalan Mar 22, 2021

Choose a reason for hiding this comment

Uh oh!

fgalan Mar 22, 2021

Choose a reason for hiding this comment

Uh oh!

sromerotech Mar 22, 2021

Choose a reason for hiding this comment

Uh oh!

fgalan Mar 22, 2021

Choose a reason for hiding this comment

Uh oh!

fgalan commented Mar 23, 2021

Uh oh!

fgalan Mar 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sromerotech commented Mar 26, 2021

Uh oh!

fgalan commented Mar 26, 2021

Uh oh!

sromerotech commented Mar 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fgalan commented Mar 29, 2021

Uh oh!

fgalan commented Apr 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fgalan commented Apr 13, 2021

Uh oh!

fgalan commented May 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fgalan Mar 26, 2021 •

edited

Loading

sromerotech commented Mar 29, 2021 •

edited

Loading

fgalan commented Apr 9, 2021 •

edited

Loading