Skip to content

Comments

FIX additional fixes on top PR #1721#1759

Merged
AlvaroVega merged 1 commit intomasterfrom
attribute-loss-when-updating-a-device-extra-fixes
Feb 4, 2026
Merged

FIX additional fixes on top PR #1721#1759
AlvaroVega merged 1 commit intomasterfrom
attribute-loss-when-updating-a-device-extra-fixes

Conversation

@fgalan
Copy link
Member

@fgalan fgalan commented Feb 4, 2026

Some additional fixes on top of PR #1721

CC: @edwinvautier

@fgalan fgalan requested a review from AlvaroVega February 4, 2026 09:10
//remove measures that have been shadowed by an alias (some may be left and managed later)
//Maybe we must filter object_id if there is name == object_id
measures = measures.filter((item) => item.name !== currentAttr.object_id && item.name !== currentAttr.name);
measures = measures.filter((item) => item.name !== currentAttr.object_id);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To align with the same change in NGSIv2 done in PR #1721

Copy link
Member

@AlvaroVega AlvaroVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlvaroVega AlvaroVega merged commit 8509e15 into master Feb 4, 2026
12 checks passed
@fgalan fgalan deleted the attribute-loss-when-updating-a-device-extra-fixes branch February 4, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants