Refactor shell commands on container init #1170
Merged
+21
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the shell commands to a script, `init-dirs.sh`, and embed it in the binary. This makes it easier to maintain the shell script without Rust escapes and no line breaks. Change the script behavior to not only copy the contents of `/tmp/pg_sharedir` if sharedir is empty, but also always copy the contents of `/tmp/pg_pkglibdir`, as a minor version upgrade might include improvements or bug fixes.
nhudson
approved these changes
Feb 28, 2025
theory
force-pushed
the
refactor-init-sh
branch
from
db5cbaf to
e951ce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the shell commands to a script,
init-dirs.sh, and embed it in the binary. This makes it easier to maintain the shell script without Rust escapes and no line breaks.Change the script behavior to not only copy the contents of
/tmp/pg_sharedirif sharedir is empty, but also always copy the contents of/tmp/pg_pkglibdir, as a minor version upgrade might include improvements or bug fixes.