Eliminate need for /tmp/pg_sharedir
#1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mount the `pgdata` volume in the `tembo-init` container to `/var/lib/postgresql/init` instead of `/var/lib/postgresql/data`. This leaves the contents of `data` from the image in place, and we can simply copy them to `init`, eliminating the need for the images to have copied data to `/tmp/pg_sharedir`. Update `init-dirs.sh` to make this copy, but switch to `cp --recursive --update`, which will update files but not delete any other files. This will allow change such as minor Postgres version updates to shared libraries to be copied over, ensuring they're consistent with the version of Postgres from the image. Remove the `/tmp/pg_pkglibdir` copy, as well, as it is included in `data`, and simplify the deletion of `/var/lib/postgresql/data/lost+found` (which should not be in any of our images anyway).
theory
changed the title
/tmp/pg_sharedir (#1185)/tmp/pg_sharedir
nhudson
approved these changes
Mar 12, 2025
theory
added a commit
to tembo-io/tembo-images
that referenced
this pull request
Mar 12, 2025
Go back to using `/var/lib/postgresql/data` instead of `/var/lib/postgresql/tembo` because, although it made it compatible with stock CNPG, it was incompatible with Tembo Cloud, which also relies on CNPG, so it would never be mounted. It means the image will no longe be compatible with stock CNPG, sadly, because `/var/lib/postgresql/data/share` is still the shared directory, and CNPG will wipe it out when it mounts the `pgdata` volume at `/var/lib/postgresql/data`. Also remove the copying of the contents of `/var/lib/postgresql/data` to `/tmp/pg_sharedir` and `/tmp/pg_pkglibdir` from all images. As of tembo-io/tembo#1185, the init pod now copies files directly from `/var/lib/postgresql/data`.
theory
added a commit
that referenced
this pull request
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mount the
pgdatavolume in thetembo-initcontainer to/var/lib/postgresql/initinstead of/var/lib/postgresql/data. This leaves the contents ofdatafrom the image in place, and we can simply copy them toinit, eliminating the need for the images to have copied data to/tmp/pg_sharedir.Update
init-dirs.shto make this copy, but switch tocp --recursive --update, which will update files but not delete any other files. This will allow change such as minor Postgres version updates to shared libraries to be copied over, ensuring they're consistent with the version of Postgres from the image.Remove the
/tmp/pg_pkglibdircopy, as well, as it is included indata, and simplify the deletion of/var/lib/postgresql/data/lost+found(which should not be in any of our images anyway).