install: install system dependencies defined in Trunk.toml with an additional flag #934
Conversation
| @@ -0,0 +1,102 @@ | |||
| use std::{ | |||
There was a problem hiding this comment.
This file basically duplicates what we did for pgxn-deps. If we publish the pgxn_deps crate, Trunk could use the crate directly and remove this duplication
There was a problem hiding this comment.
pgxn-deps might evolve into something, but not in the immediate future. Seems fine to just copy it here.
| pub dependencies: Option<HashMap<String, Vec<String>>>, | ||
| /// A list of extensions the extension being installed depends on | ||
| pub extension_dependencies: Option<Vec<String>>, |
There was a problem hiding this comment.
The comment was tagged on the wrong variable
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
vrmiguel
force-pushed
the
tem-3064
branch
6 times, most recently
from
862ff76 to
6db1008
Compare
| @@ -59,9 +59,11 @@ which = "4.4.0" | |||
| lazy_static = "1.5.0" | |||
| fastrand = "2.1.0" | |||
| regex = "1.11.1" | |||
| mockcmd = { version = "0.0.1" } | |||
There was a problem hiding this comment.
Shouldn't this only be a dev dependency?
There was a problem hiding this comment.
It's both! We also set it under dev-dependencies. In non-dev, however, it's just a rename for std::process::Command
Line 69 in dc142ae
| let host_arch = if cfg!(test) { | ||
| "x86_64" | ||
| } else { | ||
| std::env::consts::ARCH | ||
| }; |
There was a problem hiding this comment.
Why doesn't it work with ARM64?
There was a problem hiding this comment.
Because Trunk is limited to linux/amd64 at the moment, but we could change that in the future
No description provided.