feat: replace domain conditions with standard Ready/Progressing conditions#235
Merged
feat: replace domain conditions with standard Ready/Progressing conditions#235
Conversation
Replace the controller-specific TemporalConnectionHealthy and RolloutComplete conditions with the three standard Kubernetes conditions (Ready, Progressing, Degraded) that GitOps tools like ArgoCD and Flux can consume without custom parsing logic. - Ready=True when the target version is Current in Temporal - Progressing=True while a rollout is in-flight (WaitingForPollers, WaitingForPromotion, Ramping) - Degraded=True on any blocking error (connection failures, plan errors), regardless of whether a rollout is active Plan-gen and plan-exec failures now also set Degraded=True, where previously they only emitted a Warning event. Also adds docs/cd-rollouts.md with integration guidance for kubectl, Helm 3/4, ArgoCD (Lua health check), and Flux (Kustomization + HelmRelease). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Shivs11
reviewed
Mar 23, 2026
mnichols
reviewed
Mar 23, 2026
mnichols
left a comment
mnichols
left a comment
There was a problem hiding this comment.
I really appreciate this "going the distance" to guide people using different tools! I dont have great context on status lifecycle and cant speak to that specifically, but made some communication comments.
carlydf
commented
Mar 23, 2026
carlydf
commented
Mar 23, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jaypipes
requested changes
Mar 24, 2026
jaypipes
left a comment
jaypipes
left a comment
There was a problem hiding this comment.
I think we can simplify things for our users by just using a ConditionReady and ConditionProgressing and not the ConditionDegraded. See inline comments for explanation why :)
Shivs11
changed the title
Shivs11
reviewed
Mar 25, 2026
Shivs11
reviewed
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Deprecate the controller-specific TemporalConnectionHealthy and RolloutComplete conditions with the two standard Kubernetes conditions (Ready, Progressing) that GitOps tools like ArgoCD and Flux can consume without custom parsing logic.
Also adds docs/cd-rollouts.md with integration guidance for kubectl, Helm 3/4, ArgoCD (Lua health check), and Flux (Kustomization + HelmRelease).
Why?
Previous conditions were not easy for CD systems to consume. They were only merged to main, not included in any release, so we can still change them.
Checklist
Closes [Feature Request] Add Kubernetes status.conditions (Ready/Progressing/Degraded) for TemporalConnection and TemporalWorkerDeployment for Argo CD health #198
How was this tested:
Functional and unit tests.
Any docs updates needed?