Event Group Markers support (experimental) - #3899
Draft
laurakwhit wants to merge 13 commits into
Draft
laurakwhit wants to merge 13 commits into
laurakwhit wants to merge 13 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Adds Event Group support to the workflow Timeline and History views. Event Group Markers are displayed as grouped ranges on the timeline and available as a separate filter on both the timelines and history pages. This supports explicitly labeled markers as well as implicit signal and update markers.
Screenshots (if applicable) 📸
Design Considerations 🎨
UI and Behavior
Marker labels
Filtering
/timelineand/history.Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Run temporal server from a local build
make binsandmake starttemporal operator namespace create --namespace defaultRun the UI against a local build of temporal server
laura/fe-212-timeline-shows-event-groupsbranch in the UI repocd server/ && make buildcd .. && pnpm dev:local-temporalpnpm catalog workerand go to http://localhost:3000/namespaces/default/catalog/timelineand/historypages.Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
FE-211FE-212FE-213Docs
Any docs updates needed?