Skip to content

Conversation

fcambus
Copy link

@fcambus fcambus commented Sep 22, 2025

OpenBSD also needs the _XOPEN_SOURCE_EXTENDED define.

@edgar-bonet
Copy link
Collaborator

What about NetBSD and DragonFly BSD? Would it make sense to use a test that matches all the BSDs?

@fcambus
Copy link
Author

fcambus commented Oct 14, 2025

I can't test on NetBSD or DragonFlyBSD, but I think testing for the BSD macro being defined isn't a good idea, in practice this idiom is rarely used in the wild.

I would suggest to keep this OpenBSD specific for now.

Copy link
Collaborator

@edgar-bonet edgar-bonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The CI failures are unrelated to this change. They are fixed by merging this into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants