Fix CI failure on maybe-uninitialized compiler warning #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some GCC versions say:
ttyplot.c:359:16: error:
‘y2_start’ may be used uninitialized [-Werror=maybe-uninitialized]
and a similar warning (promoted to error) for y2_end. These are false
positives: the variables are initialized if they ever get used. It is,
however, easy to restructure the code in order to get the initialization
and usage of the variables under the same ‘if’ test, so let's silence
the warning this way.
Fixes: https://github.com/tenox7/ttyplot/actions/runs/17030161145/job/48271411839
This option is not needed anymore. Furthermore, it is not supported by clang. This reverts commits 8d8d752 ("fix gh actions") and 714f210 ("fix retarded flags"). Fixes: https://github.com/tenox7/ttyplot/actions/runs/17030161145/job/48271411825
tenox7
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some GCC versions warn:
These are false positives. However, in combination with the
-Werrorcompiler option, they cause a CI failure on GCC 14 / Ubuntu.Commits 8d8d752 and 714f210 attempted to fix the failure by providing the
-Wno-error=maybe-uninitializedcompiler option. However, they did not fix the failure on Ubuntu, and they caused another failure on clang 18 on macOS:This pull request solves the issue in a different way: by moving the initialization of
y2_startandy2_endcloser to where they are used (within the sameifstatement), the warning goes away. Then, the compiler option-Wno-error=maybe-uninitializedis not needed anymore.