Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tensorflow_docs requires python3.9 #2740

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

nicolaspi
Copy link
Contributor

@nicolaspi nicolaspi commented Aug 3, 2022

Description

Brief Description of the PR:

The CI is failing with the error (e.g. #2739):

#20 2.103   File "/usr/local/lib/python3.7/site-packages/tensorflow_docs/api_generator/reference_resolver.py", line 88, in ReferenceResolver
#20 2.103     physical_path: Optional[dict[str, str]] = None,
#20 2.103 TypeError: 'type' object is not subscriptable

because tensorflow_docs is using a feature introduced in python3.9. This fix bumps the python version for the docs_tests target in tools/docker/sanity_check.Dockerfile.

Type of change

  • Bug fix

How Has This Been Tested?

Locally the command bash tools/run_build.sh run successfully after the change.

@fsx950223 fsx950223 merged commit b214e25 into tensorflow:master Aug 5, 2022
@seanpmorgan
Copy link
Member

Thanks @nicolaspi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants