Skip to content

Fix TypeError in simple_audio.ipynb #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MahdiHakkakan
Copy link

change x = data_dir/'no/01bb6a2a_nohash_0.wav'
to x = data_dir+'/no/01bb6a2a_nohash_0.wav'
to prevent a TypeError at line 819, caused by attempting to concatenate a Path object with a string.

change x = data_dir/'no/01bb6a2a_nohash_0.wav'
to x = data_dir+'/no/01bb6a2a_nohash_0.wav'
to prevent a TypeError at line 819, caused by attempting to concatenate a Path object with a string.
@MahdiHakkakan MahdiHakkakan requested a review from a team as a code owner April 2, 2025 09:49
Copy link

google-cla bot commented Apr 2, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

github-actions bot commented Apr 2, 2025

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin patch-1

Copy link
Member

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Path/str is legal.
This notebook is failing at a bunch of other places.

We can only accept changes it it runs in colab top-to bottom.

@MarkDaoust MarkDaoust added the awaiting-contributor-response Indicates a question, draft, or work-in-progress label Apr 2, 2025
Copy link

Marking this pull request as stale since it has been open for 14 days with no activity. This PR will be closed if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-contributor-response Indicates a question, draft, or work-in-progress status:stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants