Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a subset of existing lint issues #2252

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peytondmurray
Copy link

This PR fixes a bunch of existing lint issues that were automatically fixed by ruff --fix, in preparation for merging #2251. I've ignored a bunch of rule violations, but marked them in ruff.toml so that they can be systematically re-enabled and the violations fixed one by one. The vast majority of these changes are:

  • Removing useless whitespace at the end of lines
  • Making sure the end of file contains a newline
  • Removing unnecessary python 2/3 compatibility __future__ imports
  • Import sorting
  • Replacing calls to format() with f-strings, which are faster and more expressive

@peytondmurray
Copy link
Author

Not really sure about the import/copybara check - I don't know what this check is. The Ubuntu CPU check is also not visible to me. Can someone confirm that it's okay if these are not passing?

@rtg0795 rtg0795 requested a review from gharibian October 9, 2024 16:42
@rtg0795
Copy link
Contributor

rtg0795 commented Oct 9, 2024

@gharibian Would you mind taking a look at this and review.

@peytondmurray
Copy link
Author

@gharibian Is there anything I can do to help get this merged? I'd really like to get this in so that the lint workflow can get unblocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants