Skip to content

feat: Add defaults values from backup retention and backup window #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AlexSoaress
Copy link

Description

This PR introduces default fallback values for backup_retention_period and backup_window in the db_instance module.
If these variables are not explicitly set, the module now defaults to 1 day of backup retention and a backup window between 00:00-01:00 UTC.

Motivation and Context

These changes improve the module's usability and resilience by providing sensible defaults for RDS backup settings.
It avoids deployment failures due to missing required values and aligns with common best practices for backup configuration.

Breaking Changes

No breaking changes.
If the values are explicitly set in user configuration, they will continue to be respected. If omitted, the module now sets safe defaults.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@AlexSoaress AlexSoaress changed the title feat: add defaults values from backup retention and backup window feat: Add defaults values from backup retention and backup window Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant