Skip to content

Conversation

mazgi
Copy link
Contributor

@mazgi mazgi commented Aug 1, 2024

Description

Fixes #

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@mazgi mazgi requested review from a team as code owners August 1, 2024 08:43
@mazgi mazgi changed the title Update main.tf: set uniform_bucket_level_access to true feat(Cloud Storage): Enable uniform_bucket_level_access on Cloud Storage (GCS) static website sample Aug 1, 2024
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@mazgi
Copy link
Contributor Author

mazgi commented Aug 1, 2024

/gcbrun

@glasnt
Copy link
Contributor

glasnt commented Aug 13, 2024

/gcbrun

@glasnt
Copy link
Contributor

glasnt commented Sep 2, 2024

/gcbrun

Copy link
Contributor

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msampathkumar msampathkumar merged commit f529f61 into terraform-google-modules:main Sep 10, 2024
@mazgi mazgi deleted the patch-1 branch September 29, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants