Skip to content

Conversation

@pratikmore0290
Copy link
Contributor

Description

Fixes #353964666

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@pratikmore0290 pratikmore0290 requested review from a team as code owners August 21, 2024 23:29
@snippet-bot
Copy link

snippet-bot bot commented Aug 21, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment


# [START bigquery_tags_tag_key]
resource "google_tags_tag_key" "env_tag_key" {
parent = "projects/myproject1-381000"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reference project like this instead:

parent = "projects/${data.google_project.default.project_id}"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Thanks!

@pratikmore0290
Copy link
Contributor Author

/gcbrun

@glasnt
Copy link
Contributor

glasnt commented Aug 30, 2024

/gcbrun

@glasnt glasnt merged commit 9b6371d into terraform-google-modules:main Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants