-
Notifications
You must be signed in to change notification settings - Fork 286
feat(bigquery): Add example for creating a table with tag attached #734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bigquery): Add example for creating a table with tag attached #734
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
/gcbrun |
/gcbrun |
/gcbrun |
Terraform destroy is failing due to dependency issues:
I need to investigate more, as this part concerns me:
This error did not occur in #733 |
/gcbrun |
Logged upstream issue |
The resource is adding tags at creation. Since Terraform can deduce the implicit dependency of the table-resource on tag-value-resource because of the resource_tags field, the creation-order should be value-then-table. Terraform documentation mentions that both implicit and explicit dependencies should affect the order of creation and destruction. One way to explicitly mark the dependency is to use the
|
I've tried adding |
To unblock this for now, we can add |
/gcbrun |
/gcbrun |
/gcbrun |
Description
Fixes #353964666
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform apply
terraform fmt
checkIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s): https://cloud.google.com/bigquery/docs/tags#attach_tags_when_you_create_a_new_table
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review